Dropping zero minute techs - code questions

[pheonixstorm]

With the dependents patch nearly wrapped up I have been looking into adding some way to drop zero minute techs from the repair list (I have a lot of techs and the clutter is annoying) but my first attempt did not go well.

I know that the list calls getTechs() to populate the list. My first attempt modified this to actually drop the techs with 0 time left. The problem though is when I have to bring tech teams to full strength it also drops o minute techs from the list.. So, the problem I have is what to do about it.

The best solution I see is having two getTech functions. One for normal use and one for the repair/mothball/refit(?) list taking an int or bool (depending on what is used to check if overtime is allowed).

getTechs() { code... }
getTechs(bool overtime) { code... }

Is this a good way to do it or is there a preferred way you (devs) want this done?

[Netzilla]

I would go with overloading the function (basically what you've described above) in a pattern like this:

Code:

getTechs(boolean excludeZeroMinute) {
    /** do stuff **/
}

getTechs() {
    getTechs(false)
}

[pheonixstorm]

Code:

getTechs() {
    getTechs(false)
}

?? Not sure of your meaning behind this part.

[Netzilla]

Code:

getTechs() {
    getTechs(false)
}

?? Not sure of your meaning behind this part.

Put all the code for getting techs in the getTechs(boolean) method.  Then, in the original getTechs() method, simply call the new method with an argument of FALSE.  This way you avoid unnecessary code duplication.  For some examples of what I'm talking about, you can take a look at the Campaign.addFunds(long, String, int) and Campaign.addFunds(long) methods as well as the Campaign.buyPart(Part, int) and Campaign.buyPart(Part, double, int) methods.

[pheonixstorm]

I have this working fine with only one hiccup. If you use up all the time on a tech (s)he will no longer be able to mothball a mech for that day. All other aspects work fine such as refits and temp astechs.

[pheonixstorm]

Hiccups are gone now, just needed a teaspoon of sugar and all is well. Patch posted, all ready for review and hopefully inclusion into HQ.

One note. The getTechs() function is not final as i will probably have to make additional changes to it for my other tech request from 162 Repair Bay: Assigned Tech at top of list. I am thinking I will have to remove the original getTechs() and modify all existing code to use getTechs(boolean) with getTechs(boolean, techID?) as an alternate for pushing the assigned tech to the top of the list. Speculation for now anyway.